]> dgit.raspbian.org Git - gnome-shell.git/commit
modemManager: improve check for CDMA system identifier
authorCosimo Cecchi <cosimo@endlessm.com>
Sun, 26 May 2019 16:54:42 +0000 (09:54 -0700)
committerCosimo Cecchi <cosimo@endlessm.com>
Mon, 27 May 2019 15:36:05 +0000 (08:36 -0700)
commit96c24733177a5bb2ea43179ee321cb507b6cd651
tree203218c6427e56920265afd2da346b2f55271c8d
parent6359d6ef30e5430bbd6eddc6005190f461b73df6
modemManager: improve check for CDMA system identifier

Upon construction of the CDMA modem proxy, _reloadCdmaOperatorName()
is called and the value of the Sid property is read.
That property is defined as UINT32 in the D-Bus interface, but the
value may not be loaded yet after the proxy is constructed, in which
case its value will be null.

In _findProviderForSid(), we'll end up calling lookup_cdma_sid(null)
which fails with the following assertion:

gnome-shell[1082]: nma_mobile_providers_database_lookup_cdma_sid: assertion 'sid > 0' failed

This commit changes the (sid == 0) check in _findProviderForSid()
to (!sid) which will also catch the null case.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/555
js/misc/modemManager.js